Comments on: Impromptu 1.3 Finally Here!

By: trent

trent — Fri, 07 Mar 2008 18:50:08 +0000

Hey Jesse,

I think i fixed this in 1.4, I just put it out last night but didn’t change the download link. It has a couple fixes like the iframe, close “X” at the top, and the problem you found.

http://trentrichardson.com/Impromptu/scripts/jquery-impromptu.1.4.js

Hope that helps. Also just a note that might help you out, the .children will search for immediate decendants, but if you would have used .find instead it will search through all children and sub nodes. Ofcourse you could always use .find(), but .children is faster if you know the element you’re looking for is an immediate child.

Thanks for finding that!

By: Jesse

Jesse — Fri, 07 Mar 2008 16:01:50 +0000

Hi there. I’m new to Impromptu and relatively new to JQuery as well. For whatever reason the only way I could get things workingin IE (6 and 7) was to change this:

var jqib = b.append(msgbox).children(‘#’+ o.prefix +’box’);

To this:

b.append(msgbox);
var jqib = $(‘#’+ o.prefix +’box’);

Otherwise jqib was returning a null object and so on down the line. I am using the latest JQuery (1.2.3). Have no idea why that was not working. It worked fine from the get-go in FF of course. Anyway, Impromptu’s great — I can see I’ll be using it a great deal in the future.

By: trent

trent — Wed, 05 Mar 2008 13:06:20 +0000

Thanks Stewart. I am about done with the next release (1.4). I have made it an option to use the iframe or just hide the selects. I will add this to the iframe.

By: Stewart

Stewart — Wed, 05 Mar 2008 06:21:06 +0000

More info. If you put put src=”javascript:false”, the page will display the word “false” in the page. I amend this to src=”javascript:”” and it solves the problem.

By: Stewart

Stewart — Wed, 05 Mar 2008 04:01:59 +0000

*o*, the previous message should be to “trent”

By: Stewart

Stewart — Wed, 05 Mar 2008 03:52:27 +0000

Matt, for theâThis page contains secure and non-secure itemsâ popup in SSL mode, one of the workaround is to put’src=”javascript:false” for the ie6 iframe.

By: trent

trent — Thu, 28 Feb 2008 17:45:47 +0000

You can use quotes around the keys of the hash:

$.prompt(‘Example 2′,
{ buttons: { Ok: true, ‘Not Ok’: false }
})

By: Matt Wilson

Matt Wilson — Thu, 28 Feb 2008 16:25:25 +0000

Trent –

I’m still a little lost with the scenario that button text is passed in via variable, the hash always just takes in the variable name literally:

var ok = ‘not ok’;
$.prompt(‘lollerskates.’,
{ buttons: { ok : true, NO: false} }
);
});

The button will say ‘ok’ and not ‘not ok’. Do you know of a way to tell the hash to look at the variable value?

By: trent

trent — Tue, 26 Feb 2008 22:06:46 +0000

What I may do is make iframe an option, if useiframe option is true then we will use it, otherwise I will do the old fashion hide select boxes routine. It is ugly but what else can you do?? Thanks for the the thoughts and for using the plugin!

By: Matt Wilson

Matt Wilson — Tue, 26 Feb 2008 21:39:59 +0000

Thanks for the help Trent! I’ll look into sending in strings straight away.

Also, I’m not sure there’s a solution for hiding IE6 select elements correctly other than an iframe. Maybe if you let the user pass in a root domain there might be a way to properly set the source of the iframe to https://theirdomain.com. If you use createElement(‘iframe’) it inits immediately before you’re able to give it an attribute– I’m not sure what jQuery(”) would do, honestly.

Anyway thanks again for the great plugin, Trent. Simple, effective and reusable!