Trent Richardson

10 Responses

1. Wick

   12|Feb|2009 1

   That’s great, States look like a neat feature. I’m a few versions behind & just came back to your site to see what I’d missed in the meantime. Keep up the good work. I’ve used Impromptu to help with various functions (verifying user-submitted data, leaving site notifications etc) on CarComplaints.com for about a year & am very happy to donate something to support your work.

2. trent

   12|Feb|2009 2

   Glad to see there are returning users. I’m pretty excited myself about the new features and I hope others are too!

3. Wick

   12|Feb|2009 3

   A few days ago I noticed some errant padding was showing up (all browsers) above the rounded corners I’m applying to the jqi container. Today when I came here to grab the new Impromptu version, I noticed the same corners/padding problem is showing up in Example 12.

   Some troubleshooting showed the corner plugin isn’t calculating any negative top margin, which it needs to negate the 10px top padding on the jqi container. The problem only happens using slideDown as the ‘show’ effect (Example 11, using fadeIn, looks fine).

   The root problem appears to be that the corners are applied during the slideDown animation. I’m totally guessing here – I think the slideDown animation probably changed in jQuery 1.3.x so the top padding of the animated element is temporarily set to zero during the animation. It’s a good theory anyway & I’m sure someone with more time to go digging can come up with whether that’s the real reason. The errant padding doesn’t show up when using jQuery 1.2.6.

   I worked around the issue using the queue method:
   $.prompt(…etc…).children(‘#colsJqi’).queue(‘fx’,function() { $(this).corner(); });

   .. which seems to work fine. Any other ideas? A setTimeout works too but that’s even more of a hack.

4. trent

   12|Feb|2009 4

   I noticed this two when I upgraded the examples to jQuery 1.3 last night, but haven’t had a chance to look into it. I haven’t checked to see if there is a new corner plugin or not. Sure wish all the browsers supported the rounded corners with css.. :/

   You could also probably use the “load” function option on Impromptu, but that’s not really curing the problem

5. Wick

   12|Feb|2009 5

   Oops, I missed that setting in the docs. Right at the top too! :)

   Watching a 30-second slideDown with Firebug confirms that jQuery 1.3.1 animates top & bottom padding, & jQuery 1.2.6 does not.

6. Jason Roelofs

   13|Feb|2009 6

   I was half way through implementing my own “stateful” handling of prompts when I decide to check out the project’s page and look at what I find.

   Wow, talk about reading minds, this is fantastic! Thanks, impromptu is an awesome tool that just got even better.

7. trent

   16|Feb|2009 7

   Wick, The problem with the corner plugin can be solved by using fadeIn as the “show” option. A couple versions ago I chanded fadeIn to the default because of some webkit issues with forms within the prompt. So if you just remove your show option and allow fadeIn everything should work fine!

8. Ben K

   24|Feb|2009 8

   wow cool, thanks for your work trent!

   i think in the visual docs, the last parameter ‘f’ is missing from the mysubmitfunc
   i.e.
   function mysubmitfunc(v,m){
   should be
   function mysubmitfunc(v,m,f){

   i’m yet to test using states as a confirmation dialogue but i think it should work well!
   thanks again

9. Michal

   05|Mar|2009 9

   I think it will be better to replace div.jqiclose with anchor or insert anchor into this div.
   With div there is problem with styling :hover

10. trent

    05|Mar|2009 10

    Good point Michal, I will look at adding this into the next version